Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented user sessions #405

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

tusharad
Copy link
Contributor

@tusharad tusharad commented Dec 3, 2024

This PR introduces user session management for the Scotty, addressing the requirements outlined in issue #317. The implementation draws inspiration from the Scotty Session library.

Checklist:

  • Updated the changelog to reflect the new features.
  • Exposed the session management module via Web.Scotty.
  • Added comprehensive Haddock documentation for all public functions and types.
  • Included a practical example in the Example directory to demonstrate usage.
  • Developed test cases to ensure the robustness and reliability of the session management feature.

Dependency Update:

Added the random package to support the generation of session IDs. Please let me know if this addition is acceptable.

Do let me know if there are any further changes or additions you need. Thank you for reviewing this PR!

@ocramz

@tusharad tusharad changed the title Feature/user sessions Implemented user sessions Dec 3, 2024
@ocramz ocramz self-assigned this Dec 4, 2024
@ocramz
Copy link
Collaborator

ocramz commented Dec 4, 2024

@tusharad Thank you! I think this is a very good PR. Just couple of minor remarks on documentation and a return type.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants